View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001941 | T99X171.00 SKB Eagle | SW Issue | public | 2024-05-08 18:31 | 2024-07-18 10:38 |
| Reporter | (ALTech) Younkwang Jung | Assigned To | (SW) Kinbay Wu | Due Date | |
| Priority | low | Severity | s4-minor | Reproducibility | have not tried |
| Status | closed | Resolution | not fixable | ||
| Summary | 0001941: [Smart3][UI542] Review "시스템 사운드" to off at Google Settings menu | ||||
| Description | Hi Kinbay JIRA is https://jira.skbroadband.com/browse/BPM-32282 SKB is requesting to review "시스템 사운드"[system sound] off at Google Settings menu "구글 시스템 설정" --> "기기 환경설정" --> "화면 및 소리" --> 시스템 사운드 ( to off ) the attached picture file. please consider setting it to off whenever the system reboots SKB tells us to prepare for that patch Note > I will request it when it needs to be applied to UI542. And if the system sound is turned off whenever the system reboots, please check if it's not a problem with Google testing. Thank you YK.Jung | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
|
|
|
|
|
Hi Kinbay This issue is now being reviewed first by Digicap. I'll ask you after reviewing Digicap Thank you YK.Jung |
|
|
Hi Kinbay Digicap has not yet solved the issue. Please find a solution for this function - Find solution and then do not commit until getting comfirmation from SKB - SKB can also suddenly make a request for this feature. Thank you YK.Jung |
|
|
Hi Jung I want to revert a commit (9bd2f4f) about Btv notification first (https://btracker-cns.fii-foxconn.com/vaas/view.php?id=1935) Then push a new commit (as attached) to solve the two features together I've made improvements to the coding style and relocated the files to more logical locations with this new commit. If any questions let me know ====================================== commit 9bd2f4f2fe32151bfc89443671aeee2febd6b6e9 Author: Kinbay_Wu <kinbay.ty.wu@fii-foxconn.com> Date: Thu May 9 04:39:49 2024 +0800 Enable the Btv notification when boot complete Signed-off-by: Kinbay_Wu <kinbay.ty.wu@fii-foxconn.com> ====================================== Thank you Kinbay BtvNoti&SysSound.diff (2,658 bytes)
diff --git a/prebuilts/bin/vasott_script.sh b/prebuilts/bin/vasott_script.sh
index 39eec27..2a6f65b 100755
--- a/prebuilts/bin/vasott_script.sh
+++ b/prebuilts/bin/vasott_script.sh
@@ -3,6 +3,8 @@
pverifier_disable=""
stop_skbtv=""
stop_upgrade=""
+set_btv_notification="1" #Setting default turn on for every boot up
+set_system_sound="0" #Setting default turn off for every boot up
while [ true ]; do
@@ -24,6 +26,40 @@ while [ true ]; do
setprop vendor.vasott.stop_upgrade ""
fi
+ if [[ -n "$set_btv_notification" ]]; then
+ if [ "x$set_btv_notification" = "x0" ]; then
+ echo -e "Turn off Btv notification" > /dev/console
+ set_btv_notification="disallow_listener"
+ cmd notification $set_btv_notification com.skb.tv/com.skb.google.tv.fullFragment.tvapp.notification.TvNotificationListenerService
+ elif [ "x$set_btv_notification" = "x1" ]; then
+ echo -e "Turn on Btv notification" > /dev/console
+ set_btv_notification="allow_listener"
+ cmd notification $set_btv_notification com.skb.tv/com.skb.google.tv.fullFragment.tvapp.notification.TvNotificationListenerService
+ else
+ echo -e "[vendor.vasott.set_btv_notification] unknown command:$set_btv_notification " > /dev/console
+ fi
+ setprop vendor.vasott.set_btv_notification ""
+ set_btv_notification=""
+ else
+ set_btv_notification=`getprop vendor.vasott.set_btv_notification`
+ fi
+
+ if [[ -n "$set_system_sound" ]]; then
+ if [ "x$set_system_sound" = "x0" ]; then
+ echo -e "Turn off Syetem sounds" > /dev/console
+ settings put system sound_effects_enabled 0
+ elif [ "x$set_system_sound" = "x1" ]; then
+ echo -e "Turn on Syetem sounds" > /dev/console
+ settings put system sound_effects_enabled 1
+ else
+ echo -e "[vendor.vasott.set_system_sound] unknown command:$set_system_sound " > /dev/console
+ fi
+ setprop vendor.vasott.set_system_sound ""
+ set_system_sound=""
+ else
+ set_system_sound=`getprop vendor.vasott.set_system_sound`
+ fi
+
sleep 1
done
diff --git a/sepolicy/vasott_script.te b/sepolicy/vasott_script.te
index 84dcd8f..6b947a5 100644
--- a/sepolicy/vasott_script.te
+++ b/sepolicy/vasott_script.te
@@ -24,3 +24,4 @@ allow vasott_script shell_prop:property_service set;
allow vasott_script toolbox_exec:file { execute execute_no_trans getattr open read };
allow vasott_script activity_service:service_manager find;
+allow vasott_script notification_service:service_manager find;
|
|
|
Hi Kinbay, After applying the patch, our QA confirmed that there is no sound when turning off the system sound in the Dock menu. However, when set the Screen & Sound > System Sound item to On in the Google Settings menu and then set the system sound to Off in the Dock menu, sound is heard in the menu. Please check if this improvement is correct. Thank you. Kim |
|
|
Hi Kim Can I get some screenshots what is Google setting menu & Dock menu? How to reproduce this situation. Thank you Kinbay |
|
|
Hi Kinbay, I have attached some screenshots. Please refer below procedure. 1. Home menu -> "설정" -> "구글 설정" -> "구글 시스템 설정" -> "기기 환경설정" -> "화면 및 소리" -> Enable "시스템 사운드" 2. Home menu -> "설정" -> "화면/음향 설정" -> Disable "효과음" Thank you. Kim |
|
|
Hi Kinbay, After discuss with Jung, it seems that there will be no problem even with the current modifications. Please stop reviewing the issues I mentioned (#c15810). And please keep your patch. DigiCap is currently reviewing this issue to fix it. I'll let you know if there are any updates. Thank you for support. Kim |
|
|
Hi Kinbay This jira has been canceled https://jira.skbroadband.com/browse/BPM-32282 I will close this ticket Thank you YK.Jung |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | New Issue | |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | Status | new => assigned |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | Assigned To | => (SW) Kinbay Wu |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | File Added: BPM-32282_01.png | |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | File Added: BPM-32282_02.png | |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | File Added: BPM-32282_03.png | |
| 2024-05-08 18:31 | (ALTech) Younkwang Jung | File Added: BPM-32282_04.png | |
| 2024-05-08 18:32 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) SY Yoon | |
| 2024-05-08 18:32 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) JunGyu Kim | |
| 2024-05-08 18:32 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) Wooshin Kang | |
| 2024-05-08 18:32 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) Sangmin Choi | |
| 2024-05-09 12:25 | (ALTech) Younkwang Jung | Note Added: 0015733 | |
| 2024-05-09 12:25 | (ALTech) Younkwang Jung | Priority | normal => low |
| 2024-05-16 08:18 | (ALTech) Younkwang Jung | Note Added: 0015797 | |
| 2024-05-16 08:44 | (SW) Kinbay Wu | Note Added: 0015799 | |
| 2024-05-16 08:44 | (SW) Kinbay Wu | File Added: BtvNoti&SysSound.diff | |
| 2024-05-16 16:59 | (ALTech) JunGyu Kim | Note Added: 0015810 | |
| 2024-05-16 17:38 | (SW) Kinbay Wu | Note Added: 0015812 | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | Note Added: 0015814 | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 1.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 2.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 3.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 4.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 5.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 6.png | |
| 2024-05-16 17:58 | (ALTech) JunGyu Kim | File Added: 7.png | |
| 2024-05-16 18:17 | (ALTech) JunGyu Kim | Note Added: 0015816 | |
| 2024-07-18 10:38 | (ALTech) Younkwang Jung | Note Added: 0016283 | |
| 2024-07-18 10:38 | (ALTech) Younkwang Jung | Status | assigned => closed |
| 2024-07-18 10:38 | (ALTech) Younkwang Jung | Resolution | open => not fixable |








